Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache date ranges in localStorage rather than recalculating #48

Closed
Freyskeyd opened this issue Apr 4, 2014 · 7 comments
Closed

Cache date ranges in localStorage rather than recalculating #48

Freyskeyd opened this issue Apr 4, 2014 · 7 comments

Comments

@Freyskeyd
Copy link

Hey,

I've an issue with performance on my app due to ui.bootstrap.datetimepicker. I've a page with 6 datetimepicker and angular take 3 sec to boot.

Without it it take 500ms.

@dalelotts
Copy link
Owner

Can you please provide a fiddle or plunker that demonstrates the problem?

@Freyskeyd
Copy link
Author

yep i will do it

@Freyskeyd
Copy link
Author

Here:
http://plnkr.co/edit/QuKAktvoZfdNZEcWKyXR?p=info

I think we can do something with localStorage to deal with it.

@dalelotts
Copy link
Owner

Thanks for plunk - I'm seeing bootstraping: 604.701ms - is that what you are seeing? Is that much worse than you expect?

I'm afraid I don't understand how localStorage will help with the load time, can you clarify?

@Freyskeyd
Copy link
Author

It's pretty slow when entire angularJS app is bootstrap in like 100ms.

I think localStorage can help to increase date generation. Instead of loop every time to generate the same date range, do it one time and get result from localStorage.

@dalelotts
Copy link
Owner

Interesting idea - are you willing to submit a PR to use local storage? I would welcome the help!

@dalelotts dalelotts changed the title Performance issue Cache date ranges in localStorage rather than recalculating Jun 6, 2014
@dalelotts
Copy link
Owner

I'm sorry, I'm pretty slammed lately and have not gotten to this - Closing since there is no PR since June - please feel free to submit a PR if you need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants