Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the latest release is very slow #239

Closed
bagafoot opened this issue Sep 14, 2021 · 10 comments
Closed

the latest release is very slow #239

bagafoot opened this issue Sep 14, 2021 · 10 comments

Comments

@bagafoot
Copy link

I'm using pg_activity 2.2.1 release, when scroll up/down its response quite slow compared to previous releases.
It is not big deal but a little bit annoying.

@dlax
Copy link
Member

dlax commented Sep 14, 2021 via email

@bagafoot
Copy link
Author

1.5

@dpiscitelli
Copy link

Hello,

Sadly, I have to confirm this point, slower than 1.6 in my environments

@blogh
Copy link
Collaborator

blogh commented Oct 7, 2021

Hi,

Reproduced with :

pgbench -i bench
pgbench -c 90 -T 300 bench

I compared 1.6 and master and observed that :

  • Scrolling down is slower (from line to line)
  • A long press on the down key locks the UI in the "scroll down animation"
  • When reaching the last line of a page the cursor disappears for a while before appearing again a the top of the screen.

@dpiscitelli @bagafoot : does it match what you experienced ? did you see more problems ?

@dpiscitelli
Copy link

dpiscitelli commented Oct 7, 2021

@blogh That's it
To be honest, I didn't experienced others problems because I rollbacked to an older version in production... it was too unusable

@blogh
Copy link
Collaborator

blogh commented Oct 7, 2021

Note: refresh rate doesn't seem to be a factor with this. (tried from 0.5s to 5s without significant difference)

@bagafoot
Copy link
Author

bagafoot commented Oct 8, 2021

Hi,

Reproduced with :

pgbench -i bench
pgbench -c 90 -T 300 bench

I compared 1.6 and master and observed that :

  • Scrolling down is slower (from line to line)
  • A long press on the down key locks the UI in the "scroll down animation"
  • When reaching the last line of a page the cursor disappears for a while before appearing again a the top of the screen.

@dpiscitelli @bagafoot : does it match what you experienced ? did you see more problems ?

yeess, here the same

@blogh
Copy link
Collaborator

blogh commented Oct 20, 2021

With the PR #247, scrolling should work properly.
I think I found why it's slow and will address it in a separate PR.

Note: In pause everything is now paused : #248

@dlax dlax mentioned this issue Oct 20, 2021
@blogh
Copy link
Collaborator

blogh commented Oct 20, 2021

The performance should be better with #249.
There is still a bug related to scrolling with wrapping / ident + wrapping.

@dlax
Copy link
Member

dlax commented Dec 16, 2021

I think we can close this issue as performance problems have been resolved. The scrolling issues will be tracked in #260.

@dlax dlax closed this as completed Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants