No validation on notification setting

[dalsontws]

Turning on and off notification can be done repeatedly.
i.e. when notification setting is off, using the command "notif_off" will still show success message that that notification has been turned off.
Cannot differentiate between current notification status on the app, can only be seen in the system tray.

[nus-pe-bot]

Team's Response

Hello, thank you for your bug report!

If a user wanted to switch notifications off, it would be more important for them to know that notifications were successfully switched off rather than if they were previously switched on or off. As such, we decided to always accept notif_on or notif_off commands regardless of the app's settings. This would also prevent any confusion arising from rejecting a notif_off command but having notifications switched off.

As for tracking if notifications are currently off or on, this can be found through the command log. Given that Horo was designed for fast typers in mind, we also expected that the user would simply input notif_on and notif_off as per their intentions.

We also decided to reflect the notification status in the System Tray rather than in-app because we expected that most users would leave Horo on in the background. Notifications are primarily useful when the application is minimised, and we thought this would be when users would be most interested in checking the notification status. Nevertheless, we will take your feedback into consideration, and will consider tracking this status through the GUI in the future as well.

The severity of this bug was lowered from "Medium" to "Low" as it does not affect the functionality of the program. Users are always able to switch notifications on or off, and while it might not be straightforward to tell from the GUI if notifications are on or off, it is still possible to do so, either through the log or the System Tray. Moreover, they can always manually switch notifications on or off.

We hope that you will continue to enjoy using Horo.

Items for the Tester to Verify

❓ Issue severity

Team chose [severity.Low].
Originally [severity.Medium].

• I disagree

Reason for disagreement: [replace this with your reason]

---