Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme for fish shell #38

Closed
FelipeRosa opened this issue Oct 4, 2021 · 5 comments
Closed

Theme for fish shell #38

FelipeRosa opened this issue Oct 4, 2021 · 5 comments
Assignees

Comments

@FelipeRosa
Copy link
Contributor

Really enjoyed the theme! Would love to help to implement a port for fish shell.

@daltonmenezes
Copy link
Owner

daltonmenezes commented Oct 4, 2021

Hi @FelipeRosa , it would be great if you do this. You can start by reading the docs, also you can take a look at hyper and iTerm port implementations to help you, but feel free to ping me if you need.

To upload the fish shell icon, please send a PR to this repository.

The preview image I have to work on it, but you can upload the screenshot of fish shell with a good zoom in fullscreen and attach it in your PR here, so I can work on it to apply the right preview model.

It should be something like this, but ignore the effects:
img

Also, you can add yourself in the contributors section in your port like this

@daltonmenezes
Copy link
Owner

@FelipeRosa just a few more things.

  1. Remember to work on a branch other than the main one, example: feat/fish-shell
  2. Once the port is done, run yarn build only port-name to compile and put it together in your PR, example:
    yarn build only fish-shell

That's it 💜

@daltonmenezes
Copy link
Owner

daltonmenezes commented Oct 4, 2021

@FelipeRosa Now the Publishing ports doc is available 🚀

@FelipeRosa
Copy link
Contributor Author

Cool! Thanks a lot for the helpful tips @daltonmenezes 😄

I'll start working on something today.

@daltonmenezes
Copy link
Owner

Hi @FelipeRosa , are you still working on this port for fish shell?

Repository owner locked and limited conversation to collaborators Feb 19, 2022
@daltonmenezes daltonmenezes converted this issue into discussion #124 Feb 19, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

2 participants