Banner shows under status bar

[anthonyvallone]

Both NotificationBanner & StatusBarNotificationBanner show underneath status bar.

[anthonyvallone]

in BaseNotificationBanner.swift

if let parentViewController = parentViewController {
                parentViewController.view.addSubview(self)
                if statusBarShouldBeShown() {
                    appWindow.windowLevel = UIWindowLevelStatusBar + 1
                }
            } else {
                appWindow.addSubview(self)
                if statusBarShouldBeShown() && !(parentViewController == nil && bannerPosition == .top) {
                    appWindow.windowLevel = UIWindowLevelStatusBar + 1
                } else {
                    appWindow.windowLevel = UIWindowLevelStatusBar + 1
                }
            }

I changed the above to

if let parentViewController = parentViewController {
                parentViewController.view.addSubview(self)
                if statusBarShouldBeShown() {
                    appWindow.windowLevel = UIWindowLevelNormal
                }
            } else {
                appWindow.addSubview(self)
                if statusBarShouldBeShown() && !(parentViewController == nil && bannerPosition == .top) {
                    appWindow.windowLevel = UIWindowLevelNormal
                } else {
                    appWindow.windowLevel = UIWindowLevelStatusBar + 1
                }
            }

and now its on top, but I'm not sure if thats correct.

[Daltron]

Hi @trianglepixel! 😄 There is no need to change the code for what you are wanting to do. As the README states:

By default, each banner will be displayed on the main application window. If you are wanting to show a banner below a navigation bar, simply show on the view controller that is within the navigation system:

banner.show(on: viewController)

So what you need to do is forgo the on parameter and your banner will show above the navigation bar 👍

[anthonyvallone]

@Daltron Yes I see the issue now. Thanks.