Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to specify REDIS_PASSWORD in docker-compose #314

Closed
cirdanmiriel opened this issue Aug 3, 2021 · 7 comments
Closed

Possibility to specify REDIS_PASSWORD in docker-compose #314

cirdanmiriel opened this issue Aug 3, 2021 · 7 comments

Comments

@cirdanmiriel
Copy link

Is your feature request related to a problem? Please describe.
My use case: I am trying to set up Photonix with an existing postgres and redis server. The problem is that my current Redis server is configured so that it needs a password (that some apps, Nextcloud for example, specify via REDIS_PASSWORD). Apparently, there are currently no possibilities to specify such password throught Photonix environment variables.

Describe the solution you'd like
Add the possibility to specify Redis password throught the docker-compose.

Describe alternatives you've considered
N/A

Additional context
N/A

@cirdanmiriel cirdanmiriel changed the title Possibility to modify REDIS_PASSWORD in docker-compose Possibility to specify REDIS_PASSWORD in docker-compose Aug 3, 2021
@damianmoore damianmoore self-assigned this Aug 8, 2021
@damianmoore damianmoore added this to To do in Development tasks Aug 8, 2021
@damianmoore damianmoore moved this from To do to In progress in Development tasks Aug 8, 2021
@damianmoore
Copy link
Collaborator

damianmoore commented Aug 8, 2021

Hi @cirdanmiriel. I was just sitting down to work on this but found out that it's already implemented (since 26th June). You can see the docs for environment variables here: https://photonix.org/docs/configuration/ . Redis-related variables are REDIS_HOST, REDIS_PORT and REDIS_DB. Closing this issue now but please feel free to re-open if you are having trouble with it.

Development tasks automation moved this from In progress to Done Aug 2021 Aug 8, 2021
@cirdanmiriel
Copy link
Author

cirdanmiriel commented Aug 10, 2021

Hi @damianmoore ,
Indeed, I already populated REDIS_HOST, REDIS_PORT & REDIS_DB.
The problem I have which leads me to open this ticket is the lack of a property to define a REDIS_PASSWORD, as my Redis currently needs to provide one.

@damianmoore
Copy link
Collaborator

Hi @cirdanmiriel, really sorry. I must have misread this when I was doing some cleaning up. I'll get on this shortly - reopening now.

@damianmoore damianmoore reopened this Aug 10, 2021
Development tasks automation moved this from Done Aug 2021 to In progress Aug 10, 2021
@cirdanmiriel
Copy link
Author

Hi @cirdanmiriel, really sorry. I must have misread this when I was doing some cleaning up. I'll get on this shortly - reopening now.

No worries! And thanks for having a look at it.

@damianmoore
Copy link
Collaborator

@cirdanmiriel This is now implemented as of 10e0526 and will be included in v0.21.0 this evening.

Development tasks automation moved this from In progress to Done Aug 2021 Sep 1, 2021
@cirdanmiriel
Copy link
Author

@damianmoore it works as expected, many thanks for this !!

@damianmoore
Copy link
Collaborator

Great! Thanks for letting me know @cirdanmiriel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development tasks
Done Aug 2021
Development

No branches or pull requests

2 participants