Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring ffmpeg installation #42

Open
morsh opened this issue Sep 25, 2017 · 1 comment
Open

Ensuring ffmpeg installation #42

morsh opened this issue Sep 25, 2017 · 1 comment

Comments

@morsh
Copy link

morsh commented Sep 25, 2017

Hi,
I wanted to use ffmpeg as part of a continuous deployment strategy.
To do that I need ffmpeg to be installed automatically.

I guess that ffmpeg installation is a prerequisite for usage of this module since it's a large file.
I'd be happy to submit a PR that ensures ffmpeg is installed on a local machine (by exposing an "ensureInstallation()" method).

For a linux machine, this might be less of a problem, since you can run apt-get on shell.
But on a windows machine, this would require downloading the ffmpeg zip file, extracting it, and exposing the ffmpeg.exe file (including the other exe files).

WDYT?

@SilverGhostBS
Copy link

Personally I think the constructor:

const ffmpeg = new ffmpeg(videofile)

should throw an exception if ffmpeg is not installed. The generated object is completely and utterly useless if ffmpeg is not there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants