New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In The Html Report The Duration Of The Scenario Doesn't Include The Before Or After Hooks #1039
Comments
Attach JSON file with steps you are talking about |
Hi Apologies in the delay getting this to you...I include a sample JSON file which is attached below in zip format. The steps in that test are
When this JSON is sent to this module the duration of the test scenario is |
Once I calculate duration from hooks I see that overall duration is changed - what is expected but it will change duration for all projects that use duration for hooks and that makes then surprise :) |
On the other hand, hooks could be treated not as the test part but rather provisioning and then the question is: should we calculate time for preparation as the time for test? |
Hello @damianszczepanik I guess this is bit of a subjective opionion. To me it makes sense that hooks are part of the overall test duration/execution becuase ultimately you can't run the test in isolation without the provisioning. In addition if I run the test via intellij the plugin that provides feeback on the test execution also includes the provisioning as part of the overall test execution. Please see the attachment for more details So doing so probably aligns with the cucumber eco system per se. |
Hi there,
If you look at the HTML report per the screenshot below:
the scenario has a duration of
2.537
while one of the before hooks has a duration of3.445
. It looks like the duration for a scenario is calculated by summing the durations of the steps. However when you look at the report per the screenshot thehooks
are part of the scenario so I would think the duration for the scenario should include the hook steps thus making the duration of the scenario5.996
.Thoughts?
The text was updated successfully, but these errors were encountered: