Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with silent renew when js execution has been suspended. #605

Closed
remkoboschker opened this issue Mar 18, 2020 · 3 comments
Closed

Issue with silent renew when js execution has been suspended. #605

remkoboschker opened this issue Mar 18, 2020 · 3 comments
Labels

Comments

@remkoboschker
Copy link

We are using refresh tokens and silent renew. When js execution has been suspended (for instance when you close the lid on your mac), polling stops, the refresh token has expired en when execution resumes we get an invalid grant error from our idp. Should this trigger an attempt to log in here? https://github.com/damienbod/angular-auth-oidc-client/blob/master/projects/angular-auth-oidc-client/src/lib/services/oidc.security.service.ts#L397 Or at least update the authorazation status?

@damienbod
Copy link
Owner

@remkoboschker Not really sure here. I have the habit of always refreshing after closing my MAC book.

@remkoboschker
Copy link
Author

remkoboschker commented Apr 8, 2020

Is the issue not that a failed request with an expired refresh token should change the authorisation status?
I mean if silent renew fails it retursn of(false), but is not used either here

or here

How does the application know that the authentication has expired?

@damienbod
Copy link
Owner

@remkoboschker This is fixed in verions 11, thanks for reporting

Greetings Damien

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants