Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration via forRoot(...) method #747

Closed
FabianGosebrink opened this issue May 20, 2020 · 1 comment · Fixed by #1041
Closed

Configuration via forRoot(...) method #747

FabianGosebrink opened this issue May 20, 2020 · 1 comment · Fixed by #1041
Assignees
@FabianGosebrink
Labels
breaking_changes

Comments

@FabianGosebrink
Copy link
Collaborator

FabianGosebrink commented May 20, 2020 •
edited

To be more consistent with general angular libraries the configuration should move from the APP_INITIALIZER to the forRoot(...) method. We have ot take care that the sample with loading via http config can also use the forRoot config.

We still have to draw this but this would be a breaking change

Docs
Code
Samples
@FabianGosebrink FabianGosebrink self-assigned this May 20, 2020
This was referenced Apr 12, 2021
Merged
Closed
@FabianGosebrink
Copy link
Collaborator Author

Implemented, will be in Release 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FabianGosebrink FabianGosebrink

Labels
breaking_changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make configuration easier and moved APP_INITIALIZER into the lib damienbod/angular-auth-oidc-client
1 participant
@FabianGosebrink