Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create WalletService and update WalletModel #7

Open
damoonrashidi opened this issue Apr 15, 2020 · 4 comments
Open

Create WalletService and update WalletModel #7

damoonrashidi opened this issue Apr 15, 2020 · 4 comments
Assignees

Comments

@damoonrashidi
Copy link
Owner

WalletModel needs the following public method

class WalletValue {
  double amount;
  double value;
}
WalletContents getContents(Wallet wallet);

And WalletService needs the following methods, since they will be pretty different API calls with different methods.

WalletContents _getBitcoinValue(String address);
WalletContents _getEthereumValue(String address);
WalletContents ...
@Deepanshu-Rohilla
Copy link

I can work on this. But I am not sure if this project is active now. Please respond to this comment if this project is still active.

@damoonrashidi
Copy link
Owner Author

It is! I work on it every other week or so when work is chill. Recently added BCH and BTC wallet balance lookup, and ETH+other coins is already in there now.

So whatever you feel like adding just go right ahead. The generator function and all the boilerplate is already in place

@deveshtiwary19
Copy link

Can you assign me this issue! I can work on it if it's still active.

@damoonrashidi
Copy link
Owner Author

damoonrashidi commented Oct 10, 2022

Sure thing @deveshtiwary19 go right ahead! Let me know if you need any help, it's been a while since I've been in this repo, but I might be able to point you in the right direction if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants