Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show translation if same text #1996

Closed
benthecarman opened this issue Feb 9, 2024 · 5 comments
Closed

Don't show translation if same text #1996

benthecarman opened this issue Feb 9, 2024 · 5 comments
Labels
help-wanted Extra attention is needed localization

Comments

@benthecarman
Copy link
Contributor

If the translation is the same as the original text it should just hide it.

image

@benthecarman benthecarman changed the title Don't show translation if same tezt Don't show translation if same text Feb 9, 2024
@alltheseas
Copy link
Collaborator

#1959

@kernelkind
Copy link
Contributor

#1959

This one is challenging because the translation is different. The original text has the ` character but the translated text has the ' apostrophe character

@jb55
Copy link
Collaborator

jb55 commented Feb 12, 2024 via email

@benthecarman
Copy link
Contributor Author

That could make sense. Had one today that was 'wat' -> 'what'. Technically different but essentially the same.

@alltheseas alltheseas added localization help-wanted Extra attention is needed labels Feb 13, 2024
@kernelkind
Copy link
Contributor

kernelkind commented Feb 13, 2024

I'm going to start working on this issue and interpret the validation criteria as implementing a string distance algorithm for deciding what the 'same' text is

@jb55 jb55 closed this as completed in 58326f6 Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted Extra attention is needed localization
Projects
Status: No status
Development

No branches or pull requests

4 participants