Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep keyword in view / highlight keyword when scrolling in search #2047

Open
alltheseas opened this issue Mar 13, 2024 · 3 comments
Open

Keep keyword in view / highlight keyword when scrolling in search #2047

alltheseas opened this issue Mar 13, 2024 · 3 comments
Labels
design Design exploration & definition is required good-first-issue Good for newcomers search

Comments

@alltheseas
Copy link
Collaborator

user story

As a Damus user searching for a keyword, I would like a way to be reminded of the keyword I searched for as I am scrolling down the note results, so that I can keep focus on the keyword.

acceptance criteria.

  1. There is a method to remind user of the keyword searched for as user is scrolling in search note view

design exploration

@robagreda what do you think?

  1. highlight keyword in all notes with results (MOCKUP below)
    HIGHLIGHTS

  2. keep a header row that contains and perpetually displays the keyword searched for (see example for google web search in browser)
    Screenshot 2024-03-13 at 10 49 40 AM

@alltheseas alltheseas added design Design exploration & definition is required search labels Mar 13, 2024
@robagreda
Copy link
Contributor

I like your mockup @alltheseas maybe just remove the orange border and round those corners.

Keeping the search filed when scrolling also is needed and I like it.

@jb55
Copy link
Collaborator

jb55 commented Mar 16, 2024

I wanted to do this but it was a bit complicated to add for v1.

@alltheseas
Copy link
Collaborator Author

HIGHLIGHTS (1)

@ericholguin

@alltheseas alltheseas added the good-first-issue Good for newcomers label Mar 25, 2024
@alltheseas alltheseas changed the title Keep keyword in view when scrolling in search Keep keyword in view / highlight keyword when scrolling in search May 7, 2024
@alltheseas alltheseas mentioned this issue May 7, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design exploration & definition is required good-first-issue Good for newcomers search
Projects
Status: Backlog
Development

No branches or pull requests

3 participants