Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back-port Thai translations to 1.8 release branch #2213

Closed
danieldaquino opened this issue May 6, 2024 · 8 comments
Closed

Back-port Thai translations to 1.8 release branch #2213

danieldaquino opened this issue May 6, 2024 · 8 comments
Assignees
Labels
localization translations Automated DeepL translations, etc

Comments

@danieldaquino
Copy link
Contributor

ISO 639-1 Language Code: th
ISO 639-2 Language Code: tha

@danieldaquino danieldaquino self-assigned this May 6, 2024
@danieldaquino danieldaquino added the translations Automated DeepL translations, etc label May 6, 2024
@danieldaquino
Copy link
Contributor Author

Related to: #2201

@danieldaquino
Copy link
Contributor Author

Commits of interest for back-porting:

c15f045 Translate Localizable.stringsdict in th
43fc662 Translate Localizable.strings in th
d2b7878 Translate InfoPlist.strings in th

@danieldaquino
Copy link
Contributor Author

New commit of interest for cherry-picking/back-porting: 8133da8

@danieldaquino
Copy link
Contributor Author

@jb55 @alltheseas

I am getting non-trivial merge conflicts when cherry-picking 8133da8 to the release branch

There seems to be enough localization changes (new translations in various languages, some changes to localization code, new localization definitions and configurations that the Thai translations may depend on, etc) that this back-port strategy might not be ideal.

I will try a new strategy. I will try cherry-picking every localization/translation change not present in 1.8, and see if that route works better.

@danieldaquino
Copy link
Contributor Author

I will try a new strategy. I will try cherry-picking every localization/translation change not present in 1.8, and see if that route works better.

This worked without any merge conflicts. Now doing a quick smoke test

@danieldaquino
Copy link
Contributor Author

Quickly ran the app in Thai and 3 other languages. Localization seems to be working as expected.

@danieldaquino
Copy link
Contributor Author

The cherry-picked commits:

bb8dba6 Add Thai as a supported language
c7d0802 Translate Localizable.stringsdict in th
b47b331 Translate Localizable.strings in th
addd5cb Translate InfoPlist.strings in th
5ef9835 Translate Localizable.strings in zh_TW
b818145 Translate Localizable.strings in zh_HK
7b93b81 Translate Localizable.strings in zh_CN
b590dab Translate Localizable.stringsdict in zh_TW
b40db66 Translate Localizable.stringsdict in zh_HK
3662209 Translate Localizable.stringsdict in zh_CN
83c661b Translate Localizable.stringsdict in vi
77d8cdf Translate Localizable.strings in vi
fa2116e Translate Localizable.strings in es_ES
3137e3a Translate Localizable.strings in es_ES
c31bee1 Translate Localizable.strings in es_ES
4fabc00 Translate Localizable.stringsdict in es_ES
968c311 Translate Localizable.strings in de
6e44e57 Translate Localizable.strings in de
68e97ca Translate Localizable.strings in de
8b48658 Translate Localizable.stringsdict in de
709b7f3 Translate Localizable.strings in de
54c09a8 Translate Localizable.strings in nl
0615428 Translate Localizable.stringsdict in nl
fc9af11 Fix localization issues
2cadded Add Finnish translations
066b257 Translate Localizable.strings in fa
b193192 Translate Localizable.strings in ko
f7187c2 Translate Localizable.strings in pl_PL

@danieldaquino
Copy link
Contributor Author

@jb55 @tyiu, successfully back-ported localization changes from 1.9 (master) to the 1.8 release branch. Thai translations will be available on the upcoming 1.8 release!

Closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization translations Automated DeepL translations, etc
Projects
Status: Live
Development

No branches or pull requests

2 participants