Bug: cannot add relays

[alltheseas]

What happens
When I remove all relays but one, and I try to add I cannot successfully add a relay.

What I expect to happen
I expect to be able to add relays.

** Versions **
Damus version: 1.9 (7)

Steps to reproduce the behavior:

1. Open Damus
2. Add new relay (relay.zap.store)
3. Remove all other relays
4. Attempt to add relay

[alltheseas]

@danieldaquino I seem to remember this was an issue previously - where relays could not be added. Is this a regression?

[alltheseas]

Would first aid help here with restoring working relays?

[danieldaquino]

Would first aid help here with restoring working relays?

Please do not use First Aid (yet), or you will lose your follow list.

I will try to repro your issue and see if I can find any workarounds to get your account working again.

[danieldaquino]

Reproduced. Finding a workaround

[danieldaquino]

@alltheseas one workaround that worked for me was to delete and reinstall Damus. This is probably the fastest workaround.

You would lose bookmarks if you did this, though.

If you don't want to lose bookmarks, I can prioritize creating a new first aid option (or a full fix if time permits).

Are you ok with reinstalling or do you prefer to wait a bit more for the first-aid/fix?

[alltheseas]

Works now, thanks.

what was the cause?

[danieldaquino]

what was the cause?

1. It fails to add a relay because it requires a contact list to be loaded on the app, but in this scenario it fails to load.
2. The contact list fails to load for 2 reasons:
   1. The newly added relay does not have the contact list event
   2. In this particular scenario, damus_state.settings.latest_contact_event_id_hex is nil, meaning it could not load from NostrDB
3. damus_state.settings.latest_contact_event_id_hex is nil for two reasons
   1. Under this scenario, the account was created before we introduced the changes from Confirm contact list creation during account creation #2057
   2. The ContactsDelegate protocol function latest_contact_event_changed (which is responsible for setting this value each time a new contact list is detected) should have been called at some point, but it seems like it hasn't been in this scenario. The reason why it wasn't is still unclear to me 🤔 it will require more investigation

[danieldaquino]

Found it

    /// This loads the latest contact event we have on file from NostrDB. This should be called as soon as we get the new DamusState
    /// Loading the latest contact list event into our `Contacts` instance from storage is important to avoid getting into weird states when the network is unreliable or when relays delete such information
    func load_latest_contact_event_from_damus_state() {
        guard let latest_contact_event_id_hex = damus_state.settings.latest_contact_event_id_hex else { return }
        guard let latest_contact_event_id = NoteId(hex: latest_contact_event_id_hex) else { return }
        guard let latest_contact_event: NdbNote = damus_state.ndb.lookup_note( latest_contact_event_id)?.unsafeUnownedValue?.to_owned() else { return }
        process_contact_event(state: damus_state, ev: latest_contact_event)
        damus_state.contacts.delegate = self // Here
    }

Unless the user signs up after #2057 changes, this delegate will never be set, which means latest_contact_event_changed will never get called. This line needs to be moved up probably

[jb55]

On Fri, Jun 14, 2024 at 12:20:30PM GMT, Daniel D’Aquino wrote: Found it ```swift /// This loads the latest contact event we have on file from NostrDB. This should be called as soon as we get the new DamusState /// Loading the latest contact list event into our `Contacts` instance from storage is important to avoid getting into weird states when the network is unreliable or when relays delete such information func load_latest_contact_event_from_damus_state() { guard let latest_contact_event_id_hex = damus_state.settings.latest_contact_event_id_hex else { return } guard let latest_contact_event_id = NoteId(hex: latest_contact_event_id_hex) else { return } guard let latest_contact_event: NdbNote = damus_state.ndb.lookup_note( latest_contact_event_id)?.unsafeUnownedValue?.to_owned() else { return } process_contact_event(state: damus_state, ev: latest_contact_event) damus_state.contacts.delegate = self // Here } ``` Unless the user signs up after #2057 changes, this delegate will never be set, which means `latest_contact_event_changed` will never get called. This line needs to be moved up probably

awesome, thanks for digging into this!