Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understand traces for Guardians of Galaxy video #23

Closed
danalex97 opened this issue Jun 21, 2020 · 9 comments
Closed

Understand traces for Guardians of Galaxy video #23

danalex97 opened this issue Jun 21, 2020 · 9 comments
Labels

Comments

@danalex97
Copy link
Owner

^

@danalex97 danalex97 added high priority High priority. study labels Jun 21, 2020
@danalex97
Copy link
Owner Author

This may be useful: AbandonRequestRule @ https://github.com/Dash-Industry-Forum/dash.js/wiki/ABR-Logic

@danalex97
Copy link
Owner Author

danalex97 commented Jun 22, 2020

We need to implement something like this that talks to the backend in order to abandon segments that could possibly cause rebuffering: https://github.com/Dash-Industry-Forum/dash.js/blob/development/src/streaming/rules/abr/AbandonRequestsRule.js

@danalex97
Copy link
Owner Author

@danalex97
Copy link
Owner Author

Check onFragmentLoadProgress from https://github.com/Dash-Industry-Forum/dash.js/blob/b90898e81f08c52384f1003c201b74476bf1531d/src/streaming/controllers/AbrController.js for the handling of abandoned fragments.

@danalex97
Copy link
Owner Author

danalex97 commented Jun 23, 2020

If the abandons don't work, we can try to change the quality by hand and stop the XMLHttp request via abort.

@danalex97
Copy link
Owner Author

danalex97 commented Jun 23, 2020

Update bc4df6b: since we intercept the normal request, the fragment model has no requests, thus the check if (request) fails:

                const fragmentModel = streamProcessor.getFragmentModel();
                const request = fragmentModel.getRequests({state: FragmentModel.FRAGMENT_MODEL_LOADING, index: e.request.index})[0];

Nope, seems to be working...

@danalex97
Copy link
Owner Author

New idea:

@danalex97
Copy link
Owner Author

@danalex97
Copy link
Owner Author

Should be partly fixed by 1cbcd43 - ad06eeb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant