Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons are not appearing #59

Closed
atulS7inc opened this issue Oct 23, 2017 · 6 comments
Closed

Icons are not appearing #59

atulS7inc opened this issue Oct 23, 2017 · 6 comments

Comments

@atulS7inc
Copy link

atulS7inc commented Oct 23, 2017

I've gone through all the process and also linked the font-awesome css in my "index.html" which is mentioned in Readme file. But still, icons are not appearing.

Icon is rendered successfully and i can see that in DOM -
<span aria-hidden="true" class="fa fa-rocket fa-3x"></span>

Using react version 15.6.1 and react-fontawesome version 1.6.1

Thanks!

@danawoodman
Copy link
Owner

@atulS7inc can you check the "Network" tab in Chrome DevTools and make sure the fonts are being loaded for FontAwesome? You may not have the paths in your CSS pointing to the fonts correctly. Reopen if it's still an issue!

@jseminck
Copy link

jseminck commented Nov 5, 2017

I ran into the same issue. The "problem" for me was that on the npm website, this is the first thing that I read:

Features
No dependencies (other than React)

I assumed that because of no other dependencies, I also did not have to include font-awesome in one way or another... of course, below the list it does mention the following... but it was easy to read over this. 😄

Note: This component does not include any of the Font Awesome CSS or fonts, so you'll need to make sure to include those on your end somehow, either by adding them to your build process or linking to CDN versions.

@danawoodman
Copy link
Owner

@jseminck a PR to make the readme more clear is welcome 😇

@freereikicourse
Copy link

+1 Second time installing and still need to google how to make this thing work... ughhh frustrating

@freereikicourse
Copy link

The readme could have some simple steps:

  • Install font-awesome with this command...
  • Import the css with this: import 'font-awesome/css/font-awesome.css';

@danawoodman
Copy link
Owner

@freereikicourse that is assuming someone is using WebPack and misses some steps (CSS loader, etc). I've updated readme to have info on the CDN version and to link to a blog post on how to get FontAwesome working with WebPack. Hopefully this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants