Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show help by default when no arguments provided #36

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Show help by default when no arguments provided #36

merged 1 commit into from
Oct 16, 2018

Conversation

tanmayrajani
Copy link
Contributor

Closes #20

@danburzo
Copy link
Owner

Looks good! Can we do something similar for when no command is invoked? I find myself doing percollate --output ... instead of percollate pdf --output .... Or maybe we run pdf by default when no other command is invoked?

@danburzo
Copy link
Owner

Also, we've started splitting the CLI into a separate cli.js file; sorry for breaking your PR :-) Can you put it in cli.js instead?

@tanmayrajani
Copy link
Contributor Author

Yes, fortunately, I was watching the repo and knew those changes! :)

@tanmayrajani
Copy link
Contributor Author

There seems to be some issues with the default command in commander but I've figured that the changes I ended up with in above commit works just right. Let me know your opinion/suggestions

@danburzo
Copy link
Owner

Let's merge it as-is for now. It would be great to raise an issue with commander.js to get a second opinion on how to best achieve this.

@danburzo danburzo merged commit abc589f into danburzo:master Oct 16, 2018
@danburzo
Copy link
Owner

Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants