Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-page anchors on github.com pages don't work #49

Closed
danburzo opened this issue Oct 16, 2018 · 1 comment
Closed

In-page anchors on github.com pages don't work #49

danburzo opened this issue Oct 16, 2018 · 1 comment
Labels
Available This issue is up for grabs Bug Something isn't working

Comments

@danburzo
Copy link
Owner

danburzo commented Oct 16, 2018

For example:

percollate pdf https://github.com/danburzo/percollate

Will result in a PDF where the links in the Table of Contents doesn't work:

danburzopercollate.pdf

(produced on macOS / percollate@0.2.10)

I may be dense, but I can't tell how the anchors work in browsers in the first place 😰 (Later edit: the behavior is dependent on JavaScript — of course 😄 )

@danburzo danburzo added the Bug Something isn't working label Oct 16, 2018
@danburzo
Copy link
Owner Author

danburzo commented Oct 16, 2018

It works correctly, however, if the pages are published on GH Pages, e.g. https://danburzo.github.io/toolbox/

So the bug seems to be related to the weird way GitHub works with anchors; let's treat this as a low-priority, Github-specific enhancement.

@danburzo danburzo changed the title In-page anchors on GitHub pages don't work In-page anchors on github.com pages don't work Oct 16, 2018
@danburzo danburzo added the Available This issue is up for grabs label Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Available This issue is up for grabs Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant