Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Add a test that enforces clippy and rustfmt compliance #384

Closed
dandavison opened this issue Nov 7, 2020 · 5 comments
Closed

馃殌 Add a test that enforces clippy and rustfmt compliance #384

dandavison opened this issue Nov 7, 2020 · 5 comments

Comments

@dandavison
Copy link
Owner

Once the codebase is clippy-compliant, let's add a test that ensures it stays that way. (And the same for rustfmt). cc @MarcoIeni ref #380 #383

@MarcoIeni
Copy link
Contributor

I know how to do it by using github actions. See this.
I don't know if you have plans to use them.

@dandavison
Copy link
Owner Author

I'm happy to switch to GitHub actions if that makes sense. But I'm thinking that's pretty much orthogonal to this issue since we can add shell commands here

delta/etc/ci/script.sh

Lines 10 to 15 in b149425

cargo test --target "$TARGET" --verbose
cargo build --release
./tests/test_raw_output_matches_git_on_full_repo_history
./tests/test_deprecated_options > /dev/null
cargo run --target "$TARGET" -- < /dev/null

@MarcoIeni
Copy link
Contributor

I'm happy to switch to GitHub actions if that makes sense.

I don't know, that's just what I happen to use for my open source projects, but yes, it's a separate issue.

Anyway, the commands should be the following:

cargo fmt --all -- --check
cargo clippy -- -D warnings

@dandavison
Copy link
Owner Author

Update: we've got a check for rustfmt, and a check for clippy commented out; the only remaining thing here is getting the codebase to pass clippy.

@dandavison
Copy link
Owner Author

Fixed at #422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants