New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] Replace getParent() by findAncestorWithClass() method #164
Comments
Comment by tduchateau from Wednesday Jun 26, 2013 at 07:03 GMT Indeed, that would be great. |
Comment by eruiz from Wednesday Jun 26, 2013 at 07:31 GMT Thibault, I could do the pull-request asap ... ok? |
Comment by tduchateau from Wednesday Jun 26, 2013 at 07:53 GMT Go for it! ;-) |
Comment by tduchateau from Wednesday Jul 10, 2013 at 06:01 GMT Hi Enrique, Normally it should work properly when your create a new branch dedicated to a pull request from your dandelion-datatables' master branch but this branch needs to remain untouched (at least up to date with the upstream). Your issue appears to be the fact that you merged one your pull requests in your master branch. That's why the pull #7 embeds commits of the pull #6. So, what do we do now? :-)
Regards, |
Comment by eruiz from Wednesday Jul 10, 2013 at 07:52 GMT Hi Thibault, agree. If you prefer:
Regards, Enrique |
Comment by tduchateau from Wednesday Jul 10, 2013 at 11:46 GMT
Thanks Enrique! |
Comment by eruiz from Thursday Jul 11, 2013 at 06:29 GMT Done! PR 8 ready |
Comment by tduchateau from Thursday Jul 11, 2013 at 12:48 GMT See #8 |
Issue by eruiz from Tuesday Jun 25, 2013 at 17:33 GMT
TagSupport.getParent() method gives us access to parent TableTag as follows:
The problem is getParent() doesn't let us to compose tables as shown below:
To solve it, we can use the method TagSupport.findAncestorWithClass() in spite of getParent() method:
The text was updated successfully, but these errors were encountered: