Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Add Tag support for EL expressions at attribute's values #172

Closed
tduchateau opened this issue Jan 28, 2014 · 6 comments
Closed
Milestone

Comments

@tduchateau
Copy link
Member

Issue by eruiz from Friday Jul 05, 2013 at 15:05 GMT


Sometimes Tag attribute's value must be dynamically calculated at runtime by an EL expression.

The Tag attributes that enables the support for EL values must be defined in the TLD as follows:

<attribute>
   <description>Table's height to display in scrolling mode.
      (default : 300px)</description>
   <name>scrollY</name>
   <rtexprvalue>true</rtexprvalue>
</attribute>

Imho it could be a good enhancement to set rtexprvalue=true to all Tags attributes.

@tduchateau
Copy link
Member Author

Comment by tduchateau from Friday Jul 05, 2013 at 15:11 GMT

I have no problem with that! It would indeed prevent some future issues from being raised. :-)

@tduchateau
Copy link
Member Author

Comment by eruiz from Friday Jul 05, 2013 at 15:13 GMT

I see ... if do you agree with this enhancement I will try to do the pull-request asap ... :)

@tduchateau
Copy link
Member Author

Comment by tduchateau from Friday Jul 05, 2013 at 15:15 GMT

Go for it! :-)
FI, I'll try to close the v0.9.0 by the end of the next week.

Thanks Enrique.

@tduchateau
Copy link
Member Author

Comment by eruiz from Friday Jul 05, 2013 at 15:36 GMT

Ok.

No problem, thanks to you, you are doing a great contribution to open source community.

@tduchateau
Copy link
Member Author

Comment by eruiz from Thursday Jul 11, 2013 at 06:47 GMT

PR 9 sent

Regards

@tduchateau
Copy link
Member Author

Comment by tduchateau from Thursday Jul 11, 2013 at 12:47 GMT

See #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant