Adding "Disorder" triggers some JS error relating to schema migration I believe

[yarikoptic]

While testing after

• Boost dandischema to 0.9.* series so we get support for pydantic 2.0 and schema 0.6.5 #1823
  merge ran into the case on a sample dandiset while adding a new Disorder I get an error
  

it doesn't happen when I try to add on some other dataset in the main instance (prior schema):

I then replicated on another dandiset in staging: https://gui-staging.dandiarchive.org/dandiset/210484?pos=1 so it seems to be a generic issue.

attn @waxlamp to prioritize as might delay our release with new pydantic 2.0 support

[mvandenburgh]

I created a minimal reproducible example by pulling out the "Disorder" subschema into its own JSON Schema and fed that into VJSF by itself, and this issue still occurs. So, this is actually an upstream bug in VJSF. I filed an issue here - koumoul-dev/vuetify-jsonschema-form#427

[mvandenburgh]

Upstream PR that fixes this: koumoul-dev/vuetify-jsonschema-form#428

[yarikoptic]

Thank you @mvandenburgh for a thorough dig! Is there a chance for a workaround (e.g. some way to sanitize data before giving to vjsf) just in case it would take awhile to release it ? (last release seems years back and no recent merge activity)

[satra]

fyi: last release was october - they just tag, and not use github release mechanism.

[mvandenburgh]

Thank you @mvandenburgh for a thorough dig! Is there a chance for a workaround (e.g. some way to sanitize data before giving to vjsf) just in case it would take awhile to release it ? (last release seems years back and no recent merge activity)

I think we could switch the dxdate property back to being non-nullable, although that would require another schema release. But as Satra said, VJSF still has somewhat frequent releases, and we've had success upstreaming fixes in the past so I'm hopeful we can just get this fixed upstream relatively quickly.

[yarikoptic]

ok, let's give them a day or two, but we can't wait indefinitely.

[yarikoptic]

woohoo -- the fix was merged and released now!

[yarikoptic]

confirming that on staging now I can add Disorder without error!

[satra]

does this mean, we should do a release, so we can update the CLI as well?

[yarikoptic]

it means that indeed we could orchestrate releases of both -- both masters are ready AFAIK.

[mvandenburgh]

Merging #1876 will trigger a release of the API. So whenever the associated dandi-cli PR is ready, we can merge both at the same time.

[yarikoptic]

oy, I remembered about our cli-minimal-version, e.g. as I boosted in ce47c88 so we might want to do release with a similar change, WDYT? I think the next dandi-cli release will be 0.60.0

[dandibot]

🚀 Issue was released in v0.3.77 🚀