Skip to content
This repository has been archived by the owner on Jan 14, 2022. It is now read-only.

changing download/cite buttons #921

Closed
wants to merge 4 commits into from

Conversation

djarecka
Copy link
Contributor

@djarecka djarecka commented Oct 2, 2021

changing buttons for download and cite as: removing "down arrows"

partially addressing #865

@mvandenburgh
Copy link
Contributor

mvandenburgh commented Oct 4, 2021

I looked more into this "bloop" issue, and I'm starting to think that this issue isn't actually an issue at all, but rather is in line with Vuetify's intended look/behavior. When implementing a standard dropdown with a v-menu there is a "bloop" upon clicking the button to open the dropdown in this example from the Vuetify docs, just like our Download and Cite buttons.

So I'm thinking we should leave the buttons as they are, down arrows included.

On a separate note, I think it'd be good to apply the slide-y-transition Vuetify prop to make the menu behave more like a dropdown. (edit: that slide-y link doesn't seem to work right, if you CTRL-F for "slide-y" you'll see it on that page though)

@djarecka @waxlamp what do you think?

@waxlamp
Copy link
Member

waxlamp commented Oct 4, 2021

I looked more into this "bloop" issue, and I'm starting to think that this issue isn't actually an issue at all, but rather is in line with Vuetify's intended look/behavior. When implementing a standard dropdown with a v-menu there is a "bloop" upon clicking the button to open the dropdown in this example from the Vuetify docs, just like our Download and Cite buttons.

So I'm thinking we should leave the buttons as they are, down arrows included.

On a separate note, I think it'd be good to apply the slide-y-transition Vuetify prop to make the menu behave more like a dropdown.

@djarecka @waxlamp what do you think?

I think you're right Mike, and I am just tired of the material design era. I really don't like the artificial delay built in to v-menu, but since that's standard we should just roll with it.

@djarecka, if you agree, I would revert the arrow change, add the slide-y-transition prop instead, and we can review that atlernate change instead.

@djarecka
Copy link
Contributor Author

djarecka commented Oct 4, 2021

@mvandenburgh - I've been trying to add transition="slide-y-transition" or <v-slide-y-transition> in various place, but I'm failing to change the behavior. Any suggestion where this should be added?

@waxlamp
Copy link
Member

waxlamp commented Oct 4, 2021

@mvandenburgh - I've been trying to add transition="slide-y-transition" or <v-slide-y-transition> in various place, but I'm failing to change the behavior. Any suggestion where this should be added?

If you look at the doc page Mike linked, you'll see some examples of how to use the prop in real code (click on the < > button on any example to see the code).

@djarecka
Copy link
Contributor Author

djarecka commented Oct 4, 2021

yes, I saw the examples, and I even tried to add <v-menu>, but the button disappeared.

@mvandenburgh mvandenburgh added this to In progress in Work in flight via automation Oct 7, 2021
@waxlamp
Copy link
Member

waxlamp commented Oct 14, 2021

Closing this as not a needed change. Thanks for your effort on this wild goose chase, @djarecka.

@waxlamp waxlamp closed this Oct 14, 2021
Work in flight automation moved this from In progress to Done Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants