Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"jello animation" #398

Merged
merged 8 commits into from May 12, 2015
Merged

"jello animation" #398

merged 8 commits into from May 12, 2015

Conversation

procodeing
Copy link
Contributor

Makes elements have a kinda jellylike bounce, but the element has to have it's width defined, or be a block element and be inline.
here is the pen

@yangshun
Copy link
Contributor

yangshun commented May 3, 2015

I do not see any animation in the codepen.. Tested on Safari and Chrome

@tunnckoCore
Copy link

I do not see any animation in the codepen..

👍 same here

@procodeing
Copy link
Contributor Author

????

@procodeing
Copy link
Contributor Author

Wait I fixed it

@procodeing
Copy link
Contributor Author

@yangshun @tunnckoCore I forgot to autoprefix

@procodeing
Copy link
Contributor Author

😅

@yangshun
Copy link
Contributor

yangshun commented May 4, 2015

Yep see it now! 👍

@procodeing
Copy link
Contributor Author

yay!

On 3 May 2015 at 23:11, Tay Yang Shun notifications@github.com wrote:

Yep see it now! [image: 👍]


Reply to this email directly or view it on GitHub
#398 (comment).

@tunnckoCore
Copy link

cool, looks great!

@procodeing
Copy link
Contributor Author

thank you!

@xahid
Copy link

xahid commented May 4, 2015

WOW Great

@procodeing
Copy link
Contributor Author

thank you also

@procodeing
Copy link
Contributor Author

while were waiting, Ive been making another, which you can see here

@tunnckoCore
Copy link

and what is this? what's new? what different?

@procodeing
Copy link
Contributor Author

@tunnckoCore In that one, It has a new "shiver" animation, along with the jello in that repo

@procodeing
Copy link
Contributor Author

@tunnckoCore also, You can get A sneek peek at what im working on with the fork.

@daneden
Copy link
Collaborator

daneden commented May 9, 2015

This is pretty nice! The initial stretch is a little over-the-top: maybe try dialling it down a bit?

@procodeing
Copy link
Contributor Author

@danden sure, just give me a sec.

@procodeing
Copy link
Contributor Author

@danden It will be a while, I have some work to do,besides the animation.

@procodeing
Copy link
Contributor Author

@danden and done

@daneden
Copy link
Collaborator

daneden commented May 11, 2015

Better! The first stretch is a little drawn-out now, though. It'd be great if it lasted for fewer frames. You’ll also need to rebase to the most recent commit on master.

@procodeing
Copy link
Contributor Author

@daneden ok, give me about a day, then everything should be good, the animation a bit better and shorter, and rebased

@procodeing
Copy link
Contributor Author

@daneden wait. My terminal is not being so friendly, and It wont fix the conflicts like usual, and I will have to find a fix

@procodeing
Copy link
Contributor Author

@daneden actually, give me a little longer, I have a little bit of a load

@procodeing
Copy link
Contributor Author

@daneden rebased the new and inproved animation, and made animate.min.css smaller on my pull by making the comment one line. It should be completly ready to merge now.

@daneden
Copy link
Collaborator

daneden commented May 12, 2015

Perfect. Bear in mind that the Grunt task doesn’t make the comments one-line, so next build will break this. nbd. Merging!

daneden added a commit that referenced this pull request May 12, 2015
@daneden daneden merged commit 9d4c59e into animate-css:master May 12, 2015
@daneden
Copy link
Collaborator

daneden commented May 12, 2015

@procodeing if you could open a new PR to add this animation to the gh-pages branch, that’d be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants