Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

ListFilter comment issue #27

Open
TreborT opened this issue Dec 1, 2013 · 2 comments
Open

ListFilter comment issue #27

TreborT opened this issue Dec 1, 2013 · 2 comments

Comments

@TreborT
Copy link

TreborT commented Dec 1, 2013

The summary comments for ListFilter.Exact state that this defaults to true. I think it should say it defaults to false. Maybe I've misunderstood how it's supposed to work though.

    /// <summary>
    /// optional - flag for whether to filter on exact values when filtering, 
    /// or search within content for filter values - defaults to true
    /// </summary>

I.e., if I have the following three lines,

 string listName = "Test";
  ListFilter filter = new ListFilter();
  filter.ListName = listName;

The immediate window returns false for filter.Exact.

@DDtMM
Copy link
Contributor

DDtMM commented Mar 12, 2014

@danesparza It seems to me that the property should be changed from bool Exact to bool? Exact. I'd be happy to do that today.

@danesparza
Copy link
Owner

@DDtMM Agreed. It appears to be an optional member, so that would be more appropriate. To contribute, please fork the repo, make the change and then submit a pull request.

@danesparza danesparza added the bug label Mar 12, 2014
DDtMM added a commit to DDtMM/MailChimp.NET that referenced this issue Mar 12, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants