Use stage: Infinity for webpack@4

[alexander-akait]

A lot of plugins use emit event to add own assets, manifest in 99% required only when all files were added to compilation.assets. Tapable have stage option for avoid this situation. https://github.com/webpack/tapable/blob/6b91ca9e94cf032420a57a2d0b82b627462b5c1c/lib/Hook.js#L130.

Just change from:

compiler.hooks.emit.tap('ManifestPlugin', emit);

To:

compiler.hooks.emit.tap({ name: 'ManifestPlugin', stage: Infinity}, emit);

It is allow to avoid situation when other plugin use emit event and add new assets. I agree what using hook is better, but sometimes it is impossible, because you don't have access to plugin repo.

[mastilver]

Nice! This is awesome!! :)

While you are here, I don't think it's possible but is there a way to run the webpack writes sequentially? (https://github.com/webpack/webpack/blob/0b1e9d8e09aa3f346707776f08f3307b06758d8d/lib/Compiler.js#L282)

We used to use a queue that would allow one emit event to be proceed at a time
Now rather than emitting multiple time, it just emit at the end. I think it's good but it could bring some edge cases I'm not aware yet

This was the original issue: #21
And the recent implementation change: #134

[alexander-akait]

@mastilver i think we can implement by default stage: Infinity, if somebody will have problem we can add option for this (example pluginStage or better name). But i think nobody have problem with stage, if somebody have extra assets they can use filter to avoid unnecessary data in manifest. If somebody don't have assets they can use seed. I can do PR, if you agree 👍

[mastilver]

I think we can implement by default stage: Infinity

yep totally