Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danger outputs warning but succeeds if using DANGER_GITHUB_API_TOKEN in github actions #1009

Closed
rohit-gohri opened this issue Mar 5, 2020 · 0 comments · Fixed by #1010
Closed
Assignees
Labels

Comments

@rohit-gohri
Copy link
Member

Danger step in github action:

    - name: danger
      if: github.event_name == 'pull_request'
      run: |
        yarn danger ci
      env:
        NODE_ENV: test
        CI: 1
        DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Output:

yarn run v1.22.0
$ /home/runner/work/danger-plugin-todos/danger-plugin-todos/node_modules/.bin/danger ci
You need to add GITHUB_TOKEN to your Danger action in the workflow:
  
    - name: Danger JS
      uses: danger/danger-js@X.Y.Z
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    
You need to add GITHUB_TOKEN to your Danger action in the workflow:
  
    - name: Danger JS
      uses: danger/danger-js@X.Y.Z
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    

[@octokit/rest] `const Octokit = require("@octokit/rest")` is deprecated. Use `const { Octokit } = require("@octokit/rest")` instead


[@octokit/rest] `const Octokit = require("@octokit/rest")` is deprecated. Use `const { Octokit } = require("@octokit/rest")` instead
Found only messages, passing those to review.
Feedback: https://github.com/rohit-gohri/danger-plugin-todos/pull/1#issuecomment-595348458
Done in 4.59s.

But danger works and is able to comment: rohit-gohri/danger-plugin-todos#1 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant