Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danger Swift not building with Xcode 13 beta 5 #459

Closed
DavidBrunow opened this issue Aug 30, 2021 · 1 comment
Closed

Danger Swift not building with Xcode 13 beta 5 #459

DavidBrunow opened this issue Aug 30, 2021 · 1 comment

Comments

@DavidBrunow
Copy link

DavidBrunow commented Aug 30, 2021

This issue is different than #449. When running Danger Swift with Xcode 13 the swiftc command does not execute in the same way as previous versions of Swift and therefore the Dangerfile cannot be evaluated properly. This issue is very similar to an issue that Tuist solved here: tuist/tuist#3062

From my local testing this issue can be resolved in a similar way to how Tuist resolved it. Changing swiftc to swift on this line resolves the issue I am seeing: https://github.com/danger/swift/blob/master/Sources/Runner/Commands/Runner.swift#L139

Commands generated when running swiftc on Xcode 12.5.1:

Command run

/usr/bin/swiftc --driver-mode=swift -L /Users/davidbrunow/Developer/danger/swift/.build/debug -I \
    /Users/davidbrunow/Developer/danger/swift/.build/debug -lDangerDeps -v \
    /var/folders/4w/nrtm11x923lcjhs3ml06h_780000gn/T/_tmp_dangerfile.swift runner \
    /usr/local/lib/node_modules/danger/distribution/commands/danger-local.js --process .build/debug/danger-swift \
    --passURLForDSL /var/folders/4w/nrtm11x923lcjhs3ml06h_780000gn/T/danger-dsl.json \
    /var/folders/4w/nrtm11x923lcjhs3ml06h_780000gn/T/danger-response.json

Command "generated"

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-frontend \
    -frontend -interpret /var/folders/4w/nrtm11x923lcjhs3ml06h_780000gn/T/_tmp_dangerfile.swift -Xllvm \
    -aarch64-use-tbi -enable-objc-interop -sdk /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk \
    -I /Users/davidbrunow/Developer/danger/swift/.build/debug -target-sdk-version 11.3 -module-name _tmp_dangerfile \
    -lDangerDeps -- runner /usr/local/lib/node_modules/danger/distribution/commands/danger-local.js --process \
    .build/debug/danger-swift --passURLForDSL /var/folders/4w/nrtm11x923lcjhs3ml06h_780000gn/T/danger-dsl.json \
    /var/folders/4w/nrtm11x923lcjhs3ml06h_780000gn/T/danger-response.json

Commands generated when running swiftc on Xcode 13:

Command run

/usr/bin/swiftc --driver-mode=swift -L /Users/davidbrunow/Developer/danger/swift/.build/debug -I \
    /Users/davidbrunow/Developer/danger/swift/.build/debug -lDangerDeps -v \
    /var/folders/4w/nrtm11x923lcjhs3ml06h_780000gn/T/_tmp_dangerfile.swift runner \
    /usr/local/lib/node_modules/danger/distribution/commands/danger-local.js --process .build/debug/danger-swift \
    --passURLForDSL /var/folders/4w/nrtm11x923lcjhs3ml06h_780000gn/T/danger-dsl.json \
    /var/folders/4w/nrtm11x923lcjhs3ml06h_780000gn/T/danger-response.json

Commands "generated"

/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-frontend \
    -frontend -c -primary-file /var/folders/4w/nrtm11x923lcjhs3ml06h_780000gn/T/_tmp_dangerfile.swift \
    -target arm64-apple-macosx12.0 -Xllvm -aarch64-use-tbi -enable-objc-interop -stack-check \
    -sdk /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk \
    -I /Users/davidbrunow/Developer/danger/swift/.build/debug -new-driver-path /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-driver \
    -resource-dir /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift \
    -module-name main -target-sdk-version 12.0.0 -o \
    /var/folders/4w/nrtm11x923lcjhs3ml06h_780000gn/T/TemporaryDirectory.iuenb1/_tmp_dangerfile-1.o

/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld \
    /var/folders/4w/nrtm11x923lcjhs3ml06h_780000gn/T/TemporaryDirectory.iuenb1/_tmp_dangerfile-1.o runner \
    /usr/local/lib/node_modules/danger/distribution/commands/danger-local.js .build/debug/danger-swift \
    --passURLForDSL /var/folders/4w/nrtm11x923lcjhs3ml06h_780000gn/T/danger-dsl.json \
    /var/folders/4w/nrtm11x923lcjhs3ml06h_780000gn/T/danger-response.json -v /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/clang/lib/darwin/libclang_rt.osx.a \
    -syslibroot /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk -lobjc -lSystem \
    -arch arm64 -L /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/macosx \
    -L /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk/usr/lib/swift \
    -platform_version macos 12.0.0 12.0.0 -no_objc_category_merging -L \
    /Users/davidbrunow/Developer/danger/swift/.build/debug -lDangerDeps -o main
@f-meloni
Copy link
Member

f-meloni commented Sep 13, 2021

Hi @DavidBrunow, sorry for the delay, I missed the notification for this issue :)
This is been solved in the way you were suggesting on #460, thank you, I'm closing this issue, please feel free to re open this if there are still issues :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants