Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iframe support #12

Closed
wiiittttt opened this issue Mar 30, 2016 · 5 comments
Closed

iframe support #12

wiiittttt opened this issue Mar 30, 2016 · 5 comments

Comments

@wiiittttt
Copy link

It looks like the framework for this was added as a result of #11.

I think there just needs to be another method added?

normalizeIframe(elem) { return normalizeFrame(elem); }

@pixelchutes
Copy link

👍 Yes, please!

@danhper
Copy link
Owner

danhper commented Mar 31, 2016

Thanks for reporting, this should be fixed in 0.2.3.

@pixelchutes
Copy link

@tuvistavie sorry to pester, but when testing 0.2.3 (<textarea> in <frame>), Atomic Chrome is opening up two Atom tabs...

I don't believe this happened in 0.2.2.

Oddly, it does not seem to work for a texteditor like CodeMirror (inside <frame>), but does work for CodeMirror without <frame> involved.

UPDATE:

The two Atom tabs seems to be happening even when <frame> is not involved. I'm going to attempt Restarting Chrome 51.0.2693.2 dev (64-bit) and Atom 1.6.1 seemed to resolve the duplication issue, just not sure why CodeMirror doesn't work inside of a frame?

console log:

Uncaught (in promise) TypeError: Cannot read property 'on' of undefined(…) injected.js:1

value: function(e) {
    this.editor.on("change", this.wrapSilence(e))
           //  ^^ here
}

@danhper
Copy link
Owner

danhper commented Apr 1, 2016

@pixelchutes Thanks for the catch!
I was using the window object instead of the iframe window object,
causing the error when working inside in iframe.
I just published a fix as 0.2.4, please let me know how it goes!

@pixelchutes
Copy link

@tuvistavie Confirmed, thank you! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants