Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime path #11

Closed
Perlence opened this issue Dec 17, 2015 · 5 comments
Closed

Runtime path #11

Perlence opened this issue Dec 17, 2015 · 5 comments
Milestone

Comments

@Perlence
Copy link
Contributor

Can there be an additional argument to fundle plugin to use selected subfolder of repo as root of a fish plugin? The idea comes from vim-plug.

For example, there's folder with tmuxinator completions for various shells. I could write, e.g. fundle plugin 'tmuxnator/tmuxinator' --rtp 'completion'.

@danhper
Copy link
Owner

danhper commented Dec 17, 2015

@Perlence Hi and thanks for the idea.
Actually, I have been wanting to add this for a while but did not have the time to implement it yet.
I will try to implement this when I have a moment, but any help is welcome!

@danhper danhper added this to the 1.0 milestone Dec 17, 2015
@Perlence
Copy link
Contributor Author

I'm working on it master...Perlence:repo-subfolder.

@danhper
Copy link
Owner

danhper commented Dec 19, 2015

@Perlence Great job, thank you very much!
This will also help a lot implementing the last feature I want before releasing 1.0.

Just one point, I think we can avoid having a whole state machine here,
as the only thing we need to check is the next argument.
We could simply iterate on the index, and when an argument is needed, check the next element in the list.
It is less flexible but more concise, and it should be sufficient for this use case.

https://gist.github.com/tuvistavie/15d5a9168c56c2d377f6

@danhper
Copy link
Owner

danhper commented Dec 20, 2015

@Perlence Also, we cannot use -a in fishtape tests, see fisherman/fishtape#5 for an alternative.

@Perlence
Copy link
Contributor Author

I see. I'll simplify argument parser and fix existing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants