Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlysystemOtherManager function definition incompatible #13

Closed
renardss-com opened this issue Sep 29, 2021 · 1 comment
Closed

FlysystemOtherManager function definition incompatible #13

renardss-com opened this issue Sep 29, 2021 · 1 comment

Comments

@renardss-com
Copy link

Hi all,
There seems to be an issue when using laravel 8.61.0 and danhunsaker/laravel-file-system-others v1.4.0:

Declaration of Danhunsaker\Laravel\Flysystem\FlysystemOtherManager::resolve($name) should be compatible with Illuminate\Filesystem\FilesystemManager::resolve($name, $config = NULL)

FlysystemOtherManager.php row 397

re-define protected function resolve($name) to
protected function resolve($name, $config = NULL)

and 399
$adapter = parent::resolve($name); to
$adapter = parent::resolve($name, $config);

Fixed the issue for me.
Cheers!

@danhunsaker
Copy link
Owner

See #11, #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants