Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create simple CardBody test #52

Closed
daniel-norris opened this issue Oct 18, 2020 · 2 comments · Fixed by #59
Closed

Create simple CardBody test #52

daniel-norris opened this issue Oct 18, 2020 · 2 comments · Fixed by #59
Assignees
Labels
good first issue Good for newcomers hacktoberfest Open for Hacktoberfest 2020 tests Add or improve existing tests
Milestone

Comments

@daniel-norris
Copy link
Owner

daniel-norris commented Oct 18, 2020

Is your feature request related to a problem? Please describe.
Test coverage across the application is low. We need to build confidence that the components have the expected behaviour that we want and to help mitigate any regression in the future.

Describe the solution you'd like
We need to implement better test coverage across the library. Ideally each component should be accompanied by a test case written using Jest. At a minimum the test should check whether the component successfully shows any child props. If you are able to include tests for any additional functionality then that would be appreciated!

We should have a test case covering the CardBody component implemented using Jest. More info on Jest can be found here.

For examples of how this is done, take a look at existing test cases in the library. An example would be the CardHeader or Input components.

You can run your tests using npm run test or to see test coverage across the library npm run test:cov.

This is part of epic #19.

@daniel-norris daniel-norris added good first issue Good for newcomers tests Add or improve existing tests hacktoberfest Open for Hacktoberfest 2020 labels Oct 18, 2020
@daniel-norris daniel-norris added this to the v1.0.0. milestone Oct 18, 2020
@Natalia504
Copy link
Contributor

I can take this one. Can you assign me to this one? Thanks.

@daniel-norris
Copy link
Owner Author

Hey @Natalia504 sure thing. Thanks for helping to contribute. You're assigned 😊

@daniel-norris daniel-norris added this to In progress in Release v1.0.0. Oct 18, 2020
@daniel-norris daniel-norris linked a pull request Oct 19, 2020 that will close this issue
@daniel-norris daniel-norris moved this from In progress to Done in Release v1.0.0. Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Open for Hacktoberfest 2020 tests Add or improve existing tests
Projects
Development

Successfully merging a pull request may close this issue.

2 participants