Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Typography component test to 100% coverage #72

Closed
daniel-norris opened this issue Oct 20, 2020 · 2 comments · Fixed by #75
Closed

Improve Typography component test to 100% coverage #72

daniel-norris opened this issue Oct 20, 2020 · 2 comments · Fixed by #75
Labels
hacktoberfest Open for Hacktoberfest 2020 tests Add or improve existing tests
Milestone

Comments

@daniel-norris
Copy link
Owner

Is your feature request related to a problem? Please describe.
Test coverage across the application is low. We need to build confidence that the components have the expected behaviour that we want and to help mitigate any regression in the future.

Describe the solution you'd like
We need to implement better test coverage across the library. Ideally each component should be accompanied by a test case written using Jest.

We need to improve the test coverage for the Typography component, currently implemented using Jest, to 100% coverage of the component. It currently stands at ~45%. More info on Jest can be found here (https://jestjs.io/).

image

For examples of how this is done, take a look at existing test cases in the library. An example would be the CardHeader or Input components.

You can run your tests using npm run test or to see test coverage across the library npm run test:cov.

This is part of epic #19.

@daniel-norris daniel-norris added good first issue Good for newcomers tests Add or improve existing tests hacktoberfest Open for Hacktoberfest 2020 labels Oct 20, 2020
@daniel-norris daniel-norris added this to the v1.0.0. milestone Oct 20, 2020
@daniel-norris daniel-norris removed the good first issue Good for newcomers label Oct 20, 2020
@greyGroot
Copy link
Contributor

@daniel-norris please, assign this one to me, i want to do it.

@daniel-norris
Copy link
Owner Author

Hey @greyGroot, thanks for wanting to help out but it looks like someone has beaten you to a PR submission on this one. Feel free to pick something else out or alternatively suggest an issue and PR yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Open for Hacktoberfest 2020 tests Add or improve existing tests
Projects
Development

Successfully merging a pull request may close this issue.

2 participants