Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom CardView background color #61

Merged
merged 4 commits into from Jun 17, 2017
Merged

Custom CardView background color #61

merged 4 commits into from Jun 17, 2017

Conversation

k0shk0sh
Copy link
Contributor

  • Added the ability to add custom CardView backgroundColor its useful when Apps such as FastHub has custom themes that needs to change the CardView backgroundColor.
  • Added an example showing how the color could be changed.
  • Wrapped the Activity in the AsyncTask into WeakReference to avoid leakage.

I hope you can make a new release before tomorrow :p

@daniel-stoneuk
Copy link
Owner

Sure can, I presume you've tested the demo app and all?

@k0shk0sh
Copy link
Contributor Author

Yep I did & triple confirmed :)

@daniel-stoneuk
Copy link
Owner

Awesome! Looks like a great addition - thanks very much.

@daniel-stoneuk daniel-stoneuk merged commit f2f08b5 into daniel-stoneuk:master Jun 17, 2017
@k0shk0sh
Copy link
Contributor Author

Thank you for the wonderful library :)

@daniel-stoneuk
Copy link
Owner

https://github.com/daniel-stoneuk/material-about-library/releases/tag/2.1.0

Thanks!

@k0shk0sh
Copy link
Contributor Author

@daniel-stoneuk here it is in action :p

Sent from my Htc m8 using FastHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k0shk0sh @daniel-stoneuk