Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CardView dependency in favour of MaterialCardView from Material Components #95

Closed
EdricChan03 opened this issue Sep 26, 2019 · 1 comment
Closed

Remove CardView dependency in favour of MaterialCardView from Material Components #95

EdricChan03 opened this issue Sep 26, 2019 · 1 comment

Comments

@EdricChan03
Copy link

EdricChan03 commented Sep 26, 2019 •
edited

Currently, the library uses the CardView widget from the androidx.cardview library. However, it seems that the library hasn't been maintained for a while.

A better alternative of the CardView widget would be the MaterialCardView widget which is an improved version of the CardView widget but supports the latest Material Design specs. This also removes the required dependency of the androidx.cardview library, especially if users remove this library in favour of the MaterialCardView widget.

EDIT: Turns out there's a PR for this: #94
@EdricChan03 EdricChan03 changed the title Remove CardView dependency in favour of MaterialCardView Remove CardView dependency in favour of MaterialCardView from Material Components Sep 26, 2019
@daniel-stoneuk
Copy link
Owner

Merged the PR. Thanks. I need to make these updates as well for my other apps that are now using AndroidX but I haven't got much time right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daniel-stoneuk @EdricChan03