Add round_rect #174
Open
Add round_rect #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benoît HERVIER <b@rvier.fr>
|
Are there any apps planned that need this feature? |
|
Yes i planned some watch face.
--
Benoît HERVIER - https://rvier.fr
7 mars 2021 10:01:37 Daniel Thompson <notifications@github.com>:
… Are there any apps planned that need this feature?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub[#174 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AACYBD55AIXHTOGJUZSNBYTTCM6G7ANCNFSM4YSY73VA].
[data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEgAAABICAYAAABV7bNHAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAArSURBVHic7cEBDQAAAMKg909tDjegAAAAAAAAAAAAAAAAAAAAAAAAAAA+DFFIAAEctgHwAAAAAElFTkSuQmCC###24x24:true###][Image de pistage][https://github.com/notifications/beacon/AACYBDYWTL4GDKYDHFMTVOTTCM6G7A5CNFSM4YSY73VKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOF44KNHI.gif]
|
|
Sorry for the proper review delay. I've been focussing on other projects. Anyhow I tried this out on the real watch today and had some problems. Specifically the corners of the rectangles are not being drawn. IIRC you shared several PRs using the simulator because your watch hadn't arrive yet. Are you able to test on a real device at this point? |
|
Yes, device received, didnt try the pr on device. Was also busy around other projects and trying to measure hr at regular interval.
Will take a look at it, and fix it, sorry.
28 mars 2021 10:54:38 Daniel Thompson ***@***.***>:
… Sorry for the proper review delay. I've been focussing on other projects.
Anyhow I tried this out on the real watch today and had some problems. Specifically the corners of the rectangles are not being drawn. IIRC you shared several PRs using the simulator because your watch hadn't arrive yet. Are you able to test on a real device at this point?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub[#174 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AACYBD3JJOMCWDMN5BKQYO3TF34FZANCNFSM4YSY73VA].
[data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEgAAABICAYAAABV7bNHAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAArSURBVHic7cEBDQAAAMKg909tDjegAAAAAAAAAAAAAAAAAAAAAAAAAAA+DFFIAAEctgHwAAAAAElFTkSuQmCC###24x24:true###][Image de pistage][https://github.com/notifications/beacon/AACYBD3JNGTL6RCD5AQKLADTF34FZA5CNFSM4YSY73VKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGA3FNGI.gif]
|
daniel-thompson
force-pushed
the
master
branch
2 times, most recently
from
c347898
to
4587a0a
Compare
|
Rounded rectangles would be nice for an app I'm working on building - does anyone need to test this out on a real device still? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add round_rect to draw rounded rect with his benchmark test.
Signed-off-by: Benoît HERVIER b@rvier.fr