Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SingleStepBehavior guard rail #132

Closed
daniel5151 opened this issue Mar 14, 2023 · 1 comment
Closed

Remove SingleStepBehavior guard rail #132

daniel5151 opened this issue Mar 14, 2023 · 1 comment
Labels
API-breaking Breaking API change API-cleanup minor tweak, without major usability implications gdbstub_arch Related to code in `gdbstub_arch` ready-to-go implemented in dev/ branch, awaiting release
Milestone
0.7

Comments

@daniel5151
Copy link
Owner

See #117 (comment), #128 (comment)

[the SingleStepBehavior guard rail] simply isn't workable. Behavior seems to change on the whim of which GDB client version is being used, what kind of metadata GDB lifts from the compiled binary, whether the user specified a custom target.xml, etc...

Indeed, past me might have over-engineered this thing quite a bit, and reflecting on this code again: I think a simple improvement to the error message (that mentions this upstream bug) would have been a sufficient mitigation on gdbstub's end.
@daniel5151 daniel5151 added API-breaking Breaking API change gdbstub_arch Related to code in `gdbstub_arch` API-cleanup minor tweak, without major usability implications labels Mar 14, 2023
@daniel5151 daniel5151 added this to the 0.7 milestone Mar 14, 2023
@daniel5151 daniel5151 mentioned this issue Apr 29, 2023
Closed
daniel5151 added a commit that referenced this issue Apr 29, 2023
@daniel5151
refine error message if GDB sent unsupported step packet
3c7a87c 
related to #132
@daniel5151 daniel5151 added the ready-to-go implemented in dev/ branch, awaiting release label Apr 29, 2023
@daniel5151
Copy link
Owner Author

daniel5151 commented Nov 13, 2023 •
edited
Loading

Relevant: #92 (comment)

Quite late to acknowledge this, but it seems there's actually been some movement on https://sourceware.org/bugzilla/show_bug.cgi?id=28440 (re: how certain platforms don't respect optional single stepping).

I haven't tested it, but things might finally work properly on GDB main? Would be good to check and see if we can update certain docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API-breaking Breaking API change API-cleanup minor tweak, without major usability implications gdbstub_arch Related to code in `gdbstub_arch` ready-to-go implemented in dev/ branch, awaiting release
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
1 participant
@daniel5151