Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Comments can be Lost if Page Refreshed before Blur #226

Open
danielBingham opened this issue Oct 21, 2023 · 0 comments
Open

Review Comments can be Lost if Page Refreshed before Blur #226

danielBingham opened this issue Oct 21, 2023 · 0 comments
Labels
research This is a research and discovery story. The output is documentation. story A standard story that fits in a single sprint.

Comments

@danielBingham
Copy link
Owner

Right now we save review summaries and comments on blur. However, if the user navigates away or refreshes the page before they click out of the text box, that means the content is lost. This could definitely occur and cause a user to lose a carefully crafted review, which we don't want.

However, saving onChange is not necessarily something we want to do either. On change can fire really frequently and debouncing it is not unintensive. One thing we could do is have an onChange handler that we only fire once every few seconds to save the difference. That way if someone spends a long time carefully typing up a comment, we're not firing PATCH an unreasonable amount, not doing a debounce dance, we're just checking the time and only firing if a certain amount has passed. Do that along with blur and we should be able to avoid too much loss.

@danielBingham danielBingham added research This is a research and discovery story. The output is documentation. story A standard story that fits in a single sprint. labels Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
research This is a research and discovery story. The output is documentation. story A standard story that fits in a single sprint.
Projects
Status: Backlog
Development

No branches or pull requests

1 participant