Fixes flicker when progress animation completes #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks scalessec! That's beautiful. I tested your fix in my app, and it indeed fixes that brief flicker. Daniel, I suggest you merge this fix into your repository :-) Erik |
|
Sweet, thanks @scalessec! |
danielamitay
added a commit
that referenced
this pull request
Jul 11, 2014
Fixes flicker when progress animation completes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the flicker seen when the progress animation completes, as mentioned in issue #30. The way your example project is currently setup, you don't actually see the flicker. Here's how you can test it:
I'm using iOS7 base SDK and iPhone Retina (4-inch 64-bit) simulator. In
ViewController.mcomment out[self startAnimation];on line 53 and add in[self.progressView setProgress:0.7 animated:YES];.Run the app and notice the flicker when the animation completes. Merge this branch and confirm the flicker is fixed.