Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop yarn support for development (stick to npm only) #127

Closed
danielcaldas opened this issue Oct 11, 2018 · 4 comments

Comments

@danielcaldas
Copy link
Owner

@danielcaldas danielcaldas commented Oct 11, 2018

This will avoid conflicts and the overhead of maintaining both package.json and yarn.lock. If you are picking up this issue please check out the checklist on this trello card, it should contain all the steps that we need to perform to clean up yarn relative configs.

@sasalx

This comment has been minimized.

Copy link
Contributor

@sasalx sasalx commented Oct 11, 2018

Sure I can take it. However, I didn't understand the reason for dropping yarn. Afaik lock files generated automatically so you are only maintaining package.json.

@sasalx sasalx mentioned this issue Oct 11, 2018
@danielcaldas

This comment has been minimized.

Copy link
Owner Author

@danielcaldas danielcaldas commented Oct 11, 2018

Afaik lock files generated automatically so you are only maintaining package.json

Kind of. In order for the yarn.lock to be updated you need to actually run yarn. Imagine you want to add a new dependency, you go and type:

npm install --save my-dependency

All good, package.json and package-lock.json are updated but yarn.lock is left behind unless you run the same command with yarn (or... worst... you need to do a yarn install to update yarn.lock)

@sasalx

This comment has been minimized.

Copy link
Contributor

@sasalx sasalx commented Oct 11, 2018

Oh, I see so the project mainly uses npm and keeps yarn for the sake of it.

@danielcaldas

This comment has been minimized.

Copy link
Owner Author

@danielcaldas danielcaldas commented Oct 11, 2018

Closed with #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.