Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph constantly re-rendering even when app is idle? #145

Closed
gregorykan opened this issue Nov 3, 2018 · 1 comment

Comments

@gregorykan
Copy link

@gregorykan gregorykan commented Nov 3, 2018

i noticed that my project was feeling laggy. i put a log into the graph's render function, and noticed that it was re-rendering constantly. it's consuming a lot of CPU power and that was why i observed the lagginess.

i tried not doing anything, and the re-rendering would stop after some time. however, even when i performed actions unrelated to the graph and the data being fed to the graph, the rendering would begin again. sometimes when idle it seemed to be re-rendering indefinitely.

is this normal/expected behaviour? i could understand if i was manipulating data that was being fed back into the graph, in which case of course re-rendering makes sense. but, as mentioned, re-rendering seems to occur when i am doing things completely unrelated, and when i'm not doing anything at all.

here's a gif where you can see in the dev tools that the count of 'graph render' logs is just going up and up, even though i'm not doing anything.

graph-rerendering

@gregorykan

This comment has been minimized.

Copy link
Author

@gregorykan gregorykan commented Nov 3, 2018

update: i rolled the code back really far and have found a point at which this doesn't happen. will try debug it myself - doesn't seem to be an issue with the library!

@gregorykan gregorykan closed this Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.