Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom node example is not loading on the sandbox #252

Closed
danielcaldas opened this issue Oct 20, 2019 · 4 comments
Closed

Custom node example is not loading on the sandbox #252

danielcaldas opened this issue Oct 20, 2019 · 4 comments
Assignees
Labels

Comments

@danielcaldas
Copy link
Owner

Describe the bug
Custom node link (that is accessed through ?data=custom-node) it's not working the correct dataset.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://goodguydaniel.com/react-d3-graph/sandbox/index.html?data=custom-node
  2. A warning will appear on the console.

dataset with name custom-node not found, falling back to default, make sure it is a valid dataset

Expected behavior
We should be able to visualize the amazing example with the custom node example that @LonelyPrincess set up.

Screenshots
image

Environment:

  • all
  • react-d3-graph version 2.3.0 (latest, live sandbox)

Additional context
The code to fix is located in this try/catch block sandbox/utils.js that dynamically loads the data and config for the datasets.

@Kyle-Ski
Copy link

I'll start to take a look at this. I'll also report back here if I run into any issues/

@Kyle-Ski
Copy link

Got a fix pushed up 👍 Just waiting on the CI tests now!

@danielcaldas
Copy link
Owner Author

Hey, @Kyle-Ski thanks a lot for looking into it 👍 I'll try and check it out asap.

@danielcaldas
Copy link
Owner Author

Fixed with #256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants