Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node-related callbacks are not typed properly #487

Open
andrewdildy opened this issue Jul 21, 2021 · 1 comment
Open

Node-related callbacks are not typed properly #487

andrewdildy opened this issue Jul 21, 2021 · 1 comment

Comments

@andrewdildy
Copy link

Describe the bug
In this PR, typings were added for GraphEventCallbacks.

Later, in this PR, a node argument was added to node-related callbacks. However, the typings were never updated to reflect this change.

To Reproduce

  1. Use node in any callback that accepts a node according to the docs
  2. Get a typescript error

Expected behavior
There is no typescript error.
@LazzyLizzard
Copy link

I've faced the same problem and had to use //@ts-ignore with onClickNode callback. However normal typing must be provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewdildy @LazzyLizzard