Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directional links are placed on top of each other #89

Closed
larsbuch opened this issue Jul 13, 2018 · 6 comments

Comments

@larsbuch
Copy link

@larsbuch larsbuch commented Jul 13, 2018

Directional links are placed on top of each other where Link1 (from Node1 to Node2) is placed on top of Link2 (from Node2 to Node1). It would be nice with a bend so it is distinguishable on the interface

@danielcaldas

This comment has been minimized.

Copy link
Owner

@danielcaldas danielcaldas commented Jul 15, 2018

Hi @larsbuch thanks for the feedback this is a good addition to the directional graphs feature #88. It's a work in progress.

@larsbuch

This comment has been minimized.

Copy link
Author

@larsbuch larsbuch commented Jul 16, 2018

I will look foreward to the change and test it when ready. Would you please note it here when it is checked in?

@danielcaldas

This comment has been minimized.

Copy link
Owner

@danielcaldas danielcaldas commented Jul 16, 2018

Sure thing @larsbuch

@danielcaldas

This comment has been minimized.

Copy link
Owner

@danielcaldas danielcaldas commented Jul 19, 2018

Hello @larsbuch! Coming back with some progress, a working version of bending links is available at this branch https://github.com/danielcaldas/react-d3-graph/tree/feature/bend-links you can already check it out. To make links bend you just need to pass down a config value for link.type it can be one of the following "STRAIGHT", "CURVE_SMOOTH", "CURVE_FULL".

@larsbuch

This comment has been minimized.

Copy link
Author

@larsbuch larsbuch commented Jul 19, 2018

I will test it in the weekend

@danielcaldas

This comment has been minimized.

Copy link
Owner

@danielcaldas danielcaldas commented Jul 25, 2018

Closing this with #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.