Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With Boost 1.74 and newer, use TS executor by default #79

Merged
merged 1 commit into from Aug 27, 2020

Conversation

sdebionne
Copy link
Contributor

Fixes #78

@daniele77 daniele77 merged commit 2614d33 into daniele77:master Aug 27, 2020
@daniele77
Copy link
Owner

Great. Thank you very much @sdebionne

@sdebionne sdebionne deleted the fix-boost-1-74 branch August 27, 2020 08:17
@sdebionne
Copy link
Contributor Author

@daniele77 Any chance to get a v1.2.1 with this fix, please?

@daniele77
Copy link
Owner

@sdebionne sure.

@daniele77
Copy link
Owner

daniele77 commented Aug 27, 2020

@sdebionne the release v.1.2.1 has been published

@killerbot242
Copy link

small question, is a fundamental fix in the pipeline, instead of this define, since that can ripple up, to user code which does not want this define to switch the boost asio back to the past ?

@sdebionne
Copy link
Contributor Author

I am not using Boost.Asio in my project and won't have time to provide a real fix unfortunately. I am not even sure what kind of effort we are talking about...

@daniele77
Copy link
Owner

@killerbot242 @sdebionne I created the issue #89 (remove the symbol BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT) and just fix it in commit 29fef14.
BTW: now the library can use standalone ASIO instead of BOOST ASIO. And, when you don't need remote capabilities, you don't need ASIO at all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples fail to build with Boost 1.74
3 participants