Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS providing new nonce in authorization code grant should not consume authorization code #164

Closed
jogu opened this issue Jul 27, 2022 · 3 comments

Comments

@jogu
Copy link
Contributor

jogu commented Jul 27, 2022

Related to oauth-wg/oauth-v2-1#82

This "is the authorization code consumed on an unsuccessful token endpoint operation" question seems relevant to DPoP, if an otherwise successful authorization code grant is rejected due to the AS wanting to provide a new nonce, the authorization code should presumably not be counted as 'used'. I did a quick scan of the spec but couldn't see this mentioned, I wonder if this should be spelled out?

@bc-pi
Copy link

bc-pi commented Jul 27, 2022

Yeah, the AS challenging with a new nonce would not count an authorization code as 'used'. And I believe you are quite correct that it's not mentioned in the spec. To be honest, it never even occurred to me to mention it because it seems fundamental. And a natural result of any implementation that doesn't go way out of the way to do something strange/unnecessary.

@panva
Copy link
Contributor

panva commented Jul 27, 2022

I concur that this doesn't seem like something that needs to be spelled out. It is the natural expected behaviour.

@jogu
Copy link
Contributor Author

jogu commented Jul 27, 2022

Brian apparently has more confidence in implementors than I generally do :-)

It was my expectation too, but I was surprised at the seemingly opposite expectation being expressed pretty firmly in the first comment on the above oauth 2.1 issue (link in my first comment) - not in a dpop context, admittedly.

@b---c b---c closed this as completed Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants