Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for other languages than Python ? #51

Closed
fortierq opened this issue Oct 30, 2021 · 7 comments · Fixed by #52
Closed

Support for other languages than Python ? #51

fortierq opened this issue Oct 30, 2021 · 7 comments · Fixed by #52

Comments

@fortierq
Copy link
Contributor

Hi,
I tried to use mkdocs-jupyter with OCaml notebooks. However, the syntax highlighting is incorrect.
nbconvert works correctly though.
I guess I have to change the CSS. Do you have any advice ?

@danielfrg
Copy link
Owner

Thanks for the reports, it was just that we had python hardcoded since its the one I use the most.
I am reading now the kernel language name from the ipynb json so it should be fixed on #52.

@danielfrg
Copy link
Owner

Version 0.18.1 includes the fix. let me know if you find other issues.

@fortierq
Copy link
Contributor Author

Great ! Thank you.

@fortierq
Copy link
Contributor Author

Hum... In the notebooks I have, some of them don't have the language field in kernelspec. Only something like this :

  "kernelspec": {
   "display_name": "Python 3.9.6 64-bit ('base': conda)",
   "name": "python3"
  },

I am adding them manually, but I wonder if this could be an issue with some IDE not adding those.

@danielfrg
Copy link
Owner

mmm it could be. The nbs I have have it. I added a test and it will default to python just in case.

@fortierq
Copy link
Contributor Author

fortierq commented Nov 11, 2021

It looks like the code inside markdown cells, such as
```ocaml
```
are not highlighted correctly.

For example : https://mp2i-fsm.github.io/mp2i-2021/1_ocaml/tp/tp1/

Do you know how to fix it ?

@danielfrg
Copy link
Owner

Mmm annoying... i bet those go through a different parser. I'll try to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants