Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "name": "base", "path":"C:\\odin\\base" to auto-generated ols.json to empower completions for base lib packages in ols #312

Closed
ghost opened this issue Feb 21, 2024 · 1 comment

Comments

@ghost
Copy link

ghost commented Feb 21, 2024

PLEASE DISREGARD, I WAS WRONG BELOW, GOT HELP FROM ODIN DISCORD.

Daniel, I love the Odin ols extension for VS Code!! Thank you for creating and maintaining this extension it is just so great to use and helps me as someone new to Odin!

Please consider to add base to the ols.json file that is automatically added to new Odin project folders when using ols.

When I updated the default ols.json it works.

laytan and karl thought that: maybe the autofinding code in ols for base doesn't exist yet? and that even without the collections field in the .json that ols should find the base and core folders since "they are next to the compiler"

{
    "$schema": "https://raw.githubusercontent.com/DanielGavin/ols/master/misc/ols.schema.json",
    "collections": [
        {
            "name": "core",
            "path": "C:\\odin\\core"
        },
        {
            "name": "base",
            "path": "C:\\odin\\base"
        }
    ],
    "enable_document_symbols": true,
    "enable_semantic_tokens": false,
    "enable_hover": true,
    "enable_snippets": true
}
@ghost
Copy link
Author

ghost commented Feb 22, 2024

I believe I was wrong above. When I followed some advice from the Discord server and deleted the ols.json, everything is working. Sorry for the false alarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant