Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assigning an enum to an input causes a workflow error (DSL) #916

Open
cenini opened this issue Sep 15, 2021 · 1 comment
Open

Assigning an enum to an input causes a workflow error (DSL) #916

cenini opened this issue Sep 15, 2021 · 1 comment

Comments

@cenini
Copy link

cenini commented Sep 15, 2021

Describe the bug
A clear and concise description of what the bug is.

Assigning an enum to a step input causes a workflow error even when the assigned data is of the same type, and should be directly assignable. The below JSON caused this issue

{ "Id": "SomeStep", "StepType": "SomeStepTypeWithEnumInput, SomeNamespace", "Inputs": { "MyEnum": "data[\"MyEnumKeyInIndexableData\"]" }, },

The step has a property like

public class SomeStepTypeWithEnumInput : StepBodyAsync { public MyEnum MyEnum { get; set; } ... }

To Reproduce
Load a workflow definition containing a similar step as above with the DefinitionLoader. The step cannot be run, as the input cannot be assigned to the property.

Expected behavior
The input is assigned to the property, and the step executes.

Additional context
The problem has to do with the DSL. I'll put up a pull request for fixing this issue shortly.

@LambertW
Copy link

@danielgerlag could you review and merge this request for support enum type convertible in yaml file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants